-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Commitment Discount {Quantity,Unit} - Consistency review edits #550
Commitment Discount {Quantity,Unit} - Consistency review edits #550
Conversation
Issues to be addressed in CommitemntQuantity column:
@cnharris10 @udam-f2 I believe OPTION B more clearly addresses the idea specified in the 3rd requirement Question: Is CommitmentDiscountId restricted to only Purchase and Usage, or should we also expect it in the case of Adjustment, Credit, or Tax? OPTION A: Min. updates
OPTION B: Includes reordering of bullets for readability
|
I like Option A for 2 reasons.
|
20c0f27
to
4fc7b27
Compare
Action Items from Members' call on Sep 26:
|
CommitmentDiscountQuantity OPTION C:This version retains the original flow, with a few updates compared to the original:
|
CommitmentDiscountUnitCompared to the original, in this version:
|
Action Items from TF-1 call on October 1st:
|
Update (10/2/24) All additional comments shown above were discussed in TF-1 (10/1/24) with the consensus that optimizing for readability will be pushed to 1.x after guidelines are established. The one action item that came out of the meeting was added and can be seen here |
Co-authored-by: Irena Jurica <irena.jurica@neos.hr>
Co-authored-by: Irena Jurica <irena.jurica@neos.hr>
We’ve specified that
However, CommitmentDiscountUnit MUST be null, as we didn’t mention Correction charges for that column. |
@cnharris10, @ijurica, can we resolve this issue on time for the Members' Meeting on October 3rd? Let me know if I can be of any assistance. Thanks |
@cnharris10 The sentiment of the group is that the changes Irena proposed are okay. |
Co-authored-by: Irena Jurica <irena.jurica@neos.hr>
Co-authored-by: Irena Jurica <irena.jurica@neos.hr>
@jpradocueva Just integrated both outstanding comments from @ijurica Let's move forward with it if we can. Unfortunately, not able to make the call today. |
Approved during the Members' call on Oct 3rd. |
Adds correction-based logic and reduces duplication of clauses